test: cover SearchBarComponent debounce, cache, and routing#5237
Merged
Conversation
Ma77Ball
changed the title
Contributor
Author
|
/request-review @aglinxinyuan |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new unit test suite for SearchBarComponent to verify debounce behavior, caching/eviction, type-to-name conversion, login state tracking, and routing behavior as described in Issue #5228.
Changes:
- Added
search-bar.component.spec.tswith 11 test cases covering debounce, cache hits/eviction, and argument wiring toSearchService.search. - Added tests for
isLogininitialization/updates, empty-query clearing behavior,convertToNamedispatch + throw path, andperformSearchrouting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5237 +/- ##
============================================
- Coverage 48.72% 48.68% -0.05%
- Complexity 2375 2379 +4
============================================
Files 1044 1042 -2
Lines 40096 39971 -125
Branches 4252 4252
============================================
- Hits 19538 19460 -78
+ Misses 19411 19366 -45
+ Partials 1147 1145 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aglinxinyuan
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
search-bar.component.spec.tsnext tosearch-bar.component.tswith 11 cases covering every documented behavior of the component.isLogininitialization plus live updates fromUserService.userChanged(), the empty-query clear path inonSearchInputChange,searchSubjectdebounce viafakeAsync+tick(200), the fullSearchService.searchargument list, per-query result caching, 20-entry cache eviction inaddToCache, type dispatch inconvertToName(workflow, project, file, dataset, plus the throw path), andperformSearchnavigation toDASHBOARD_SEARCH.Any related issues, documentation, or discussions?
Closes: #5228
How was this PR tested?
yarn ng test --watch=false --include "src/app/dashboard/component/user/search-bar/search-bar.component.spec.ts": 11 passed.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF